where is the error?

Sertik · Wed Oct 16, 2024 7:58 pm

There is a working script for Router OS 6 in the Scheduler that reports the admin login to the router:

:local lstime ([/system scheduler get value-name=next-run [find name="login"]] - [/system scheduler get value-name=interval [find name="login"]] * 2);
:foreach i in=[/log find message~"user admin logged in from" && time>=$lstime] do={

:log info "admin in"}

It works fine.

I want to make it work in POS 7. Since in the POS 7 log the time is indicated with the date (a different time format), I decided to use [:tonsec]
I rewrote the script this way:

:local SchedName "check_login"
:local userName "admin"

:local lstime ([:tonsec [/system scheduler get value-name=next-run [find name=$SchedName]]] - [:tonsec [/system scheduler get value-name=interval [find name=$SchedName]]] *2); 
:foreach i in=[/log find message~"user $userName logged in from" && [:tonsec time]>=$lstime] do={

:log info "admin in"}

And it doesn't work. I can't figure out where the error is?

Sertik · Thu Oct 17, 2024 9:03 am

Didn't change anything, just converted all the time intervals into seconds? ...

msatter · Thu Oct 17, 2024 10:42 am

Debugging is done in steps. I fail at the first step:

:put ([/system scheduler get value-name=next-run [find name~"Load"]])  
invalid internal item number

Is there still a next-run available in 7.x!?

erlinden · Thu Oct 17, 2024 10:48 am

I might misread (should use reading glasses), do you use ~ instead of = ?

Sertik · Thu Oct 17, 2024 11:05 am

:put ([/system scheduler get value-name=next-run [find name~"Load"]])  
invalid internal item number

Do you have a scheduler job named "Load"? next-run is in /system scheduler ROS7

It's better to be more specific, or maybe you have several tasks in the Scheduler that include “Load” in the name

:put ([/system scheduler get value-name=next-run [find name="Load"]])

Sertik · Thu Oct 17, 2024 11:06 am

I might misread (should use reading glasses), do you use ~ instead of = ?

Yes, I use ~ in

:foreach i in=[/log find message~"user $userName logged in from" && [:tonsec time]>=$lstime] do={

but who forbids me to do this?

Sertik · Thu Oct 17, 2024 11:07 am

ROS7 does not find syntax errors in my script. There's a timing error...

rextended · Thu Oct 17, 2024 3:07 pm

As usual, is missing what you try to do....

At RouterOS start memorize in one global variable

:put [/user get admin last-logged-in]

And check if is changed on scheduler.
When is changed, you know the exact time the user log in.

Works on both v6/v7

Sertik · Thu Oct 17, 2024 3:12 pm

That's it, I figured it out. This is how it works in ROS 7
[:tonsec] not needed

:local SchedName "check_login"
:local userName "admin"

:local Stime ([pick [/system scheduler get value-name=next-run [find name=$SchedName]] 11 19] - [/system scheduler get value-name=interval [find name=$SchedName]] *2); 
:foreach i in=[/log find message~"user $userName logged in from" && time>=$Stime] do={
:log info "admin in"}

in 7, last-logget-in and /shheduler next run work with the full date and time, and log time is only time. In version 6 /system scheduler, next-run only worked over time.

rextended · Thu Oct 17, 2024 3:18 pm

Still useless do all that instead of simply [/user get admin last-logged-in]

Sertik · Thu Oct 17, 2024 3:25 pm

I need it for another reason. Thank you, Teacher.

Also /user get admin last-logged-in shows the time of the last previous, and not the current login of the administrator to the router.

where is the error?

where is the error?

Re: where is the error?

Re: where is the error?

Re: where is the error?

Re: where is the error?

Re: where is the error?

Re: where is the error?

Re: where is the error?

Re: where is the error?

Re: where is the error?

Re: where is the error?

Who is online