I've got system out there at a couple different f/w levels.
At some point in the f/w development cycle, MT added error handling to scripting.
Also, at some point, under /system ntp client the mode setting had been removed. When it was initially removed, mode would still show up as a possible choice if you pressed TAB after the SET keyword.
Anyway.....
In an attempt to create a single script to support f/w's that did and didn't have that setting any longer, I thought error handling would be a good choice here.
So I came up with this....
:do {/system ntp client set mode=unicast
} err={};
...but it still throws an error!!!! I know that the mode setting was removed, and that it should error out there, if I wasn't using an error handler!!!
What gives?
Re: Error handling?
Hi.
I tried it for hours... but i concluded, that error handling works just for internal commands (which starts with : like ":resolv"),
and not works for path commands (which starts with /like "/tool dns-update..."
In the first case you can catch an error with on-error={} , in the second, command aborts the script with it's own error.
So we must send a feature request to Mikrotik... if we want to catch error in all commands.
Best regards: CsXen
I tried it for hours... but i concluded, that error handling works just for internal commands (which starts with : like ":resolv"),
and not works for path commands (which starts with /like "/tool dns-update..."
In the first case you can catch an error with on-error={} , in the second, command aborts the script with it's own error.
So we must send a feature request to Mikrotik... if we want to catch error in all commands.
Best regards: CsXen
Re: Error handling?
Going to resurrect this as I found this during my runtime error handling testing.
The syntax format has to be very specific to process the error handling properly.
Example:
So its
:do {whatever command you want to run; } on-error={whatever command you want to run if it errors}
Be mindful of the curlys and semi colons.
I recommend when trying to do error handling per command, you keep the error handling on the same line.
The syntax format has to be very specific to process the error handling properly.
Example:
Code: Select all
:do {/interface bridge add name=loopback; } on-error={:put "loopback exists"}:do {whatever command you want to run; } on-error={whatever command you want to run if it errors}
Be mindful of the curlys and semi colons.
I recommend when trying to do error handling per command, you keep the error handling on the same line.
-
-
damianivereigh
just joined
- Posts: 15
- Joined:
Re: Error handling?
I think I have to the solution to this issue. If you put the code that may have a syntax error into :parse, then you can execute that inside a do { } on-error={} and it will catch syntax errors too.
So to use your example...
:global mycode [:parse "/system ntp client set mode=unicast" ]
:do { $mycode } on-error={}
So to use your example...
:global mycode [:parse "/system ntp client set mode=unicast" ]
:do { $mycode } on-error={}
Re: Error handling?
Start to coding correctly and you do not have problems:
and about NTP, simply check first the RouterOS version...
and use this example for know if the NPT package are installed and enabled or not:
(example for Jotne for Splunk)
Code: Select all
# wrong coding
:do {/interface bridge add name=loopback; } on-error={:put "loopback exists"}
# translating: create loopback, if you got an error because already exist, ignore it
# on short: create it, hoping not already exist
# right coding
/interface bridge
:if ([:len [:find where name="loopback"]] = 0) do={add name=loopback}
# translating: if the result of the count of interface named loopback are zero, create the interface
# on short: if not exist, create it
and about NTP, simply check first the RouterOS version...
and use this example for know if the NPT package are installed and enabled or not:
(example for Jotne for Splunk)
Code: Select all
:local ntpstatus ""
:if ([:len [/system package find where !disabled and name=ntp]] > 0) do={
:set ntpstatus [/system ntp client get status]
} else={
:if ([:typeof [/system ntp client get last-update-from]] = "nil") do={
:set ntpstatus "using-local-clock"
} else={
:set ntpstatus "synchronized"
}
}
:log info message="script=ntp status=$ntpstatus"